Apply template consistency updates from TemplateDotNetTool (Polyfill, LangVersion, ThrowIfNull, AgentFiles)#113
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
AGENTS.md
Outdated
There was a problem hiding this comment.
This file doesn't seem to follow the same pattern as the template. This has extra/unnecessary sections like replicating the assert/test best practices. Please use the repo-consistency agent to actually make this consistent. Don't just keep stuff around because "well it was there before" - I'm trying to make these projects have consistent agent configurations so the agents function essentially identically. Please do the same not just for this file, but for all the agent config files.
There was a problem hiding this comment.
Done in commit ca52cd9. AGENTS.md has been replaced with the concise quick-reference format matching the template (removed duplicated Testing Guidelines, Code Style, Pre-Finalization Checklists, etc.). The .github/agents/ files were also synced: added missing Test Source Filters sections to requirements-agent.md and test-developer.md, added missing Tracking Template Evolution section to repo-consistency-agent.md, and fixed the markdownlint filename reference in code-quality-agent.md and repo-consistency-agent.md.
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Pull Request
Description
Syncs ReqStream with recent TemplateDotNetTool template changes (PRs #41, #43, #45, #46).
Source project (
DemaConsulting.ReqStream.csproj)LangVersion:12→latestPolyfill 9.12.0source-only packageSonarAnalyzer.CSharp:10.19.0→10.20.0.135146Test project (
DemaConsulting.ReqStream.Tests.csproj)<Using Include="Polyfills" />implicit usingMicrosoft.NET.Test.Sdk:18.0.1→18.3.0SonarAnalyzer.CSharp:10.19.0→10.20.0.135146Code modernization (
Context.cs,Validation.cs)ArgumentNullException.ThrowIfNullguards toContext.CreateandValidation.RunAgent configuration (
AGENTS.md,.github/agents/*.md)AGENTS.mdwith concise quick-reference format matching the template (removed sections that duplicated individual agent file content)AGENTS.md: "C# 12" → "C# latest",TemplateTool_*→ReqStream_*test naming.github/agents/requirements-agent.md.github/agents/test-developer.md.github/agents/test-developer.md.github/agents/repo-consistency-agent.md.markdownlint.json→.markdownlint-cli2.jsonc) incode-quality-agent.mdandrepo-consistency-agent.mdType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
Boolean capitalization fix (template PR #44) was already applied in ReqStream — no change needed.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.