Skip to content

Apply test naming convention, improve README, and add requirements traceability#24

Merged
Malcolmnixon merged 10 commits intomainfrom
copilot/improve-readme-and-tests
Mar 2, 2026
Merged

Apply test naming convention, improve README, and add requirements traceability#24
Malcolmnixon merged 10 commits intomainfrom
copilot/improve-readme-and-tests

Conversation

Copy link
Contributor

Copilot AI commented Mar 2, 2026

  • Fix --trace-matrix--matrix in the dotnet reqstream command in build.yaml (invalid argument)
  • Add DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER and MSBUILDDISABLENODEREUSE env vars to Runner.cs to prevent lingering MSBuild processes slowing Windows builds
  • Add MSBUILDDISABLENODEREUSE to cspell dictionary to fix quality check spell error
  • Rename requirement IDs to SPWF-GET-NNN / SPWF-ADD-NNN / SPWF-ENH-NNN format
  • Add ID naming convention section to requirements.yaml header

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits March 2, 2026 02:02
…nd reqstream tool

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…te build.yaml for TRX and reqstream

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply improvements including new unit-test naming convention Apply test naming convention, improve README, and add requirements traceability Mar 2, 2026
Copilot AI and others added 2 commits March 2, 2026 02:18
…ment out Enhance section

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
…led)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon
Copy link
Contributor

@copilot The build-docs job failed with:

Run dotnet reqstream --requirements requirements.yaml --tests "test-results/**/*.trx" --report docs/requirements/requirements.md --justifications docs/justifications/justifications.md --trace-matrix docs/tracematrix/tracematrix.md
  dotnet reqstream --requirements requirements.yaml --tests "test-results/**/*.trx" --report docs/requirements/requirements.md --justifications docs/justifications/justifications.md --trace-matrix docs/tracematrix/tracematrix.md
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
  env:
    DOTNET_ROOT: C:\Program Files\dotnet
Error: Unsupported argument '--trace-matrix' (Parameter 'args')

There is no --trace-matrix argument - the projects README.md (https://github.com/demaconsulting/ReqStream/blob/main/README.md) indicates it's --matrix

Please check a build.yaml file from a related project such as https://github.com/demaconsulting/TemplateDotNetTool/blob/main/.github/workflows/build.yaml and make sure this repo's build-docs job runs commands the same way.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 2, 2026

@copilot The build-docs job failed with:

Run dotnet reqstream --requirements requirements.yaml --tests "test-results/**/*.trx" --report docs/requirements/requirements.md --just...

Fixed in c6f7a19 — changed --trace-matrix to --matrix in the dotnet reqstream command in build.yaml.

@Malcolmnixon
Copy link
Contributor

@copilot The Windows build is taking a long time to run. Might these not be needed in the runner:

        // Disable MSBuild server and node reuse to prevent lingering child
        // processes that cause VSTest to hang waiting for process tree exit.
        startInfo.Environment["DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER"] = "1";
        startInfo.Environment["MSBUILDDISABLENODEREUSE"] = "1";

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 2, 2026

@copilot The Windows build is taking a long time to run. Might these not be needed in the runner:

        // Disable MSBuild server and node reuse to prevent lingering child

...

Added in c990261DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER and MSBUILDDISABLENODEREUSE are now set on the ProcessStartInfo in Runner.cs before spawning each child process, which should prevent lingering MSBuild nodes from slowing down the Windows build.

@Malcolmnixon
Copy link
Contributor

@copilot Quality check failures - pleas run the lint checks and fix.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 2, 2026

@copilot Quality check failures - pleas run the lint checks and fix.

Fixed in c1f2f8e — the quality check was failing because MSBUILDDISABLENODEREUSE wasn't in the cspell dictionary. Added it to .cspell.json to resolve the spell check error.

@Malcolmnixon
Copy link
Contributor

@copilot I disagree with the requirements ID format currently used - I believe it should be SPWF-GET-001 to SPWF-GET-006 for getting the version information, and SPWF-ADD-001 to SPWF-ADD-006 for adding packages.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 2, 2026 12:47
@Malcolmnixon Malcolmnixon merged commit 6b661a7 into main Mar 2, 2026
4 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/improve-readme-and-tests branch March 2, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants