Run all agents: apply improvements across API, tests, docs, requirements, and CI consistency#23
Merged
Malcolmnixon merged 5 commits intomainfrom Mar 2, 2026
Merged
Conversation
Code improvements: - Add DefaultPrefix constant and Prefix property to DemoClass - Strengthen argument validation to reject empty strings (ThrowIfNullOrEmpty) - Add XML documentation for all new members with literate comments - Add tests for DefaultPrefix, Prefix property, and empty-string validation - Update requirements.yaml with TMPL-REQ-008 and TMPL-REQ-009 - Update user guide with DefaultPrefix, Prefix, and exception documentation - Fix README to mention .NET Standard 2.0 target framework Consistency fixes (repo-consistency-agent review): - Upgrade actions/upload-artifact from v7 to v8 (matches download-artifact@v8) - Fix CONTRIBUTING.md: encoding is UTF-8 (not UTF-8 with BOM) - Fix CONTRIBUTING.md: Assert.HasCount(expectedCount, collection) argument order - Fix AGENTS.md: encoding is UTF-8 (not UTF-8+BOM)
Copilot
AI
changed the title
[WIP] Run agents to check for improvements
Run all agents: apply improvements across API, tests, docs, requirements, and CI consistency
Mar 2, 2026
Malcolmnixon
requested changes
Mar 2, 2026
| [TestClass] | ||
| public class DemoClassTests | ||
| { | ||
| // ------------------------------------------------------------------------- |
Contributor
There was a problem hiding this comment.
What are these non-xml-doc comment-blocks about?
Contributor
Author
There was a problem hiding this comment.
Those were non-standard section separator banners added by the test-developer agent — not consistent with the repo's style. Removed in 628e657.
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Mar 2, 2026
Contributor
|
@copilot Lint issues encountered - please fix. |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Contributor
Author
The CI failure was |
Contributor
|
@copilot Woah, why is upload-artifact being dropped to v4 - it should stay at v7 |
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Contributor
Author
Malcolmnixon
approved these changes
Mar 2, 2026
Malcolmnixon
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran all repository agents (requirements, software-developer, test-developer, technical-writer, code-quality, repo-consistency) to identify and apply improvements.
Description
API (
DemoClass.cs)public const string DefaultPrefix = "Hello"— eliminates magic string, provides stable API contractpublic string Prefix => _prefix— exposes active prefix for inspectionThrowIfNull→ThrowIfNullOrEmpty(rejects empty strings too)<exception>XML tags; documented private field; added literate method commentsTests (
DemoClassTests.cs)Assert.Throws<T>→Assert.ThrowsExactly<T>— enforces exact exception type (MSTest v4)DemoMethod),DefaultPrefixvalue,Prefixround-trip, default constructor storesDefaultPrefixRequirements (
requirements.yaml)ArgumentExceptionDocumentation
docs/guide/guide.md: addedDefaultPrefix,Prefix, andArgumentException(empty-string) to API referenceREADME.md: added.NET Standard 2.0to multi-runtime support list (was in csproj but missing from README)CI / Consistency fixes
build.yaml:actions/upload-artifactremains atv7(original version; erroneous bump reverted)CONTRIBUTING.md: fixed encoding description (UTF-8, notUTF-8 with BOM); fixedAssert.HasCountargument orderAGENTS.md: same encoding description fixType of Change
Related Issues
Pre-Submission Checklist
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
ArgumentException.ThrowIfNullOrEmptyis polyfilled fornetstandard2.0via the existingPolyfillpackage (<PolyArgumentExceptions>true</PolyArgumentExceptions>). No new dependencies introduced.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.