Skip to content

Add Assert.StartsWith MSTest antipattern to test-developer agent guidance#45

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/apply-pull-request-21
Feb 28, 2026
Merged

Add Assert.StartsWith MSTest antipattern to test-developer agent guidance#45
Malcolmnixon merged 2 commits intomainfrom
copilot/apply-pull-request-21

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

Pull Request

Description

Ports TemplateDotNetLibrary#21 into this template. Adds a fifth MSTest antipattern to the test-developer agent: prefer Assert.StartsWith over Assert.IsTrue(value.StartsWith(...)) for richer failure diagnostics.

// ❌ Bad: Assert.IsTrue(value.StartsWith("prefix"));
// ✅ Good: Assert.StartsWith("prefix", value);

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Documentation-only change to .github/agents/test-developer.md. No production code or tests affected.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…ance

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply changes from pull request 21 into template Add Assert.StartsWith MSTest antipattern to test-developer agent guidance Feb 28, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 28, 2026 20:57
@Malcolmnixon Malcolmnixon merged commit e5b7d8d into main Feb 28, 2026
11 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/apply-pull-request-21 branch February 28, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants