Skip to content

Add Polyfills implicit using to test project#46

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-pull-request-22
Feb 28, 2026
Merged

Add Polyfills implicit using to test project#46
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-pull-request-22

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

Pull Request

Description

Mirrors TemplateDotNetLibrary PR #22: adds an implicit using Polyfills; to the test project so Polyfill extension methods are available in test files without per-file using statements.

Polyfill is already referenced in the main project with PrivateAssets="All" and its compiled members flow into the test project via InternalsVisibleTo — no duplicate package reference needed (adding one causes CS0121 ambiguity errors).

<!-- Implicit Usings -->
<ItemGroup>
  <Using Include="Polyfills" />
</ItemGroup>

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Propagated from sister template TemplateDotNetLibrary PR #22.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ibrary PR #22)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Integrate pull request 22 from template-project Add Polyfills implicit using to test project Feb 28, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 28, 2026 21:05
@Malcolmnixon Malcolmnixon merged commit 6023bc5 into main Feb 28, 2026
11 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/bring-in-pull-request-22 branch February 28, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants