chore: sync VHDLTest with TemplateDotNetTool template updates (Feb 2026)#97
Merged
Malcolmnixon merged 2 commits intomainfrom Mar 1, 2026
Merged
chore: sync VHDLTest with TemplateDotNetTool template updates (Feb 2026)#97Malcolmnixon merged 2 commits intomainfrom
Malcolmnixon merged 2 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Mar 1, 2026
Copilot
AI
changed the title
[WIP] Update application with recent template changes
chore: sync VHDLTest with TemplateDotNetTool template updates (Feb 2026)
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies five recent commits from TemplateDotNetTool to bring VHDLTest in sync with the template.
Description
Agent guidance (
test-developer.md)ghdl@,nvc@,windows@,ubuntu@,dotnetX.x@) and why removing them invalidates CI evidenceIsTruefor equality/counts/prefix, non-public test classes)Source csproj
LangVersion:12→latestPackAsTool,IncludeSymbols,GenerateDocumentationFileTrue→trueSonarAnalyzer.CSharp:10.19.0.132793→10.20.0.135146Polyfill9.12.0 (source-only) with explanatory comments on all analyzer/source-only package groupsTest csproj
GenerateDocumentationFile:True→trueSonarAnalyzer.CSharp:10.19.0.132793→10.20.0.135146Microsoft.NET.Test.Sdk:18.0.1→18.3.0<Using Include="Polyfills" />implicit using<!-- Test Framework Dependencies -->,<!-- Code Analysis Dependencies -->,<!-- Project References -->)C# modernization
Added
ArgumentNullException.ThrowIfNull()guards toContext.Create(args)andValidation.Run(context).Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint '**/*.{yml,yaml}'Testing
Documentation
Additional Notes
No functional behavior changes — all 99 existing tests pass. The
Polyfillpackage is source-only (PrivateAssets="all"), so it adds no runtime dependency.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.