Add support for pulling images from private registries#83
Add support for pulling images from private registries#83mrBliss wants to merge 3 commits intodenibertovic:masterfrom
Conversation
Fixes denibertovic#82. `pullImage` now takes a `PullOpts` argument, which includes an optional `AuthConfig`. For more details, see: https://docs.docker.com/engine/api/v1.41/#section/Authentication
|
It seems this project has no CI. Before submitting this PR, I successfully compiled this branch with all I didn't add a test, as it would require setting up a private Docker registry, which is quite the effort. However, I did successfully test it with a private registry (using |
|
@mrBliss @denibertovic the project now has CI, how can we move this PR forward? |
|
@ocramz Sure thing. If you can resolve the conflicts in a new PR I'd be happy to merge. Also at this point I think we would be ok to drop support for 7.10 if it's too big of a hassle to support. |
Fixes #82.
pullImagenow takes aPullOptsargument, which includes an optionalAuthConfig. For more details, see:https://docs.docker.com/engine/api/v1.41/#section/Authentication