InputField: only soften line breaks inside format tags #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolayne
force-pushed
the
InputField-soft-linebreaks
branch
from
f66a895 to
55cc093
Compare
SoeAung95
approved these changes
Jan 2, 2025
Author
|
@john-preston, is there any news on this? |
kolayne
force-pushed
the
InputField-soft-linebreaks
branch
from
55cc093 to
9744711
Compare
In `InputField::PrepareForInsert`, avoid replacing all line break characters with `kSoftLine` (aka `QChar::LineSeparator`) because that makes the selection behavior inconsistent (different for typed text and restored text, e.g., from a draft). Instead, only soften line breaks inside formatting tags. Should fix telegramdesktop/tdesktop#28805
john-preston
force-pushed
the
master
branch
2 times, most recently
from
87ff4eb to
9648155
Compare
This was referenced Nov 9, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
InputField::PrepareForInsert, avoid replacing all line break characters withkSoftLine(akaQChar::LineSeparator) because that makes the selection behavior inconsistent (different for typed text and restored text, e.g., from a draft). Instead, only soften line breaks inside formatting tags.Should fix telegramdesktop/tdesktop#28805