update(deps-dev): bump eslint from 9.39.2 to 10.0.2#252
update(deps-dev): bump eslint from 9.39.2 to 10.0.2#252dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 9.39.2 to 10.0.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v9.39.2...v10.0.2) --- updated-dependencies: - dependency-name: eslint dependency-version: 10.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| "@semantic-release/release-notes-generator": "^14.0.3", | ||
| "cspell": "^9.4.0", | ||
| "eslint": "^9.39.2", | ||
| "eslint": "^10.0.2", |
There was a problem hiding this comment.
🟡 @eslint/js not bumped to v10 alongside eslint v10 major upgrade
The PR bumps eslint from ^9.39.2 to ^10.0.2 (a major version change) but leaves @eslint/js at ^9.39.2. These two packages are designed to be used in lockstep at the same major version.
Root Cause and Impact
ESLint 10's release notes explicitly include the commit chore: add eslint to peerDependencies of @eslint/js (#20467), meaning @eslint/js v10 now declares eslint as a peer dependency to enforce version alignment. Additionally, feat!: add name to configs (#20015) added name properties to built-in configs in @eslint/js v10 — the v9 configs used by this repo (js.configs.recommended at eslint.config.js:6) lack these names.
The lockfile confirms the mismatch: eslint resolves to 10.0.2 while @eslint/js resolves to 9.39.2. While the simple recommended-rules config in this repo may happen to work at runtime (since ESLint 10 didn't remove built-in rules), this is an unsupported version combination. It may cause issues with config naming/identification features new in ESLint 10, and could break on future minor updates of either package.
Fix: Bump @eslint/js in package.json from "^9.39.2" to "^10.0.2" to match the eslint major version.
Prompt for agents
In package.json, line 8, update @eslint/js from "^9.39.2" to "^10.0.2" to match the eslint major version bump. Then regenerate the package-lock.json by running npm install. The two packages are designed to be used at the same major version, and ESLint 10's @eslint/js adds peer dependency enforcement and config naming features that the v9 package lacks.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "@semantic-release/release-notes-generator": "^14.0.3", | ||
| "cspell": "^9.4.0", | ||
| "eslint": "^9.39.2", | ||
| "eslint": "^10.0.2", |
There was a problem hiding this comment.
🚩 ESLint 10 Node.js engine requirement may affect CI
The lockfile shows ESLint 10 requires node: ^20.19.0 || ^22.13.0 || >=24. This is stricter than ESLint 9 which supported ^18.18.0 || ^20.9.0 || >=21.1.0. If any CI workflows or contributor machines run Node 18.x, npm install will fail or eslint will refuse to run. This isn't a code bug per se, but the reviewer should verify that all CI environments and the documented Node version meet this requirement.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "cspell": "^9.4.0", | ||
| "eslint": "^9.39.2", | ||
| "eslint": "^10.0.2", | ||
| "eslint-config-prettier": "^10.1.8", |
There was a problem hiding this comment.
📝 Info: eslint-config-prettier remains compatible with ESLint 10
The lockfile shows eslint-config-prettier v10.1.8 declares peerDependencies: { eslint: '>=7.0.0' }, which covers ESLint 10. Since this package (eslint.config.js:7) only disables formatting rules and doesn't use any removed ESLint APIs, it remains fully compatible. No action needed.
Was this helpful? React with 👍 or 👎 to provide feedback.
Bumps eslint from 9.39.2 to 10.0.2.
Release notes
Sourced from eslint's releases.
... (truncated)
Commits
55122d610.0.280f1e29Build: changelog update for 10.0.2951223bchore: update dependency@eslint/eslintrcto ^3.3.4 (#20553)13eeedbdocs: link rule type explanation to CLI option --fix-type (#20548)6aa1afechore: update dependency eslint-plugin-jsdoc to ^62.7.0 (#20536)2b72361fix: updateajvto6.14.0to address security vulnerabilities (#20537)98cbf6bdocs: update migration guide per Program range change (#20534)61a2405docs: add missing semicolon in vars-on-top rule example (#20533)0bd549710.0.1ddb80efBuild: changelog update for 10.0.1Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)