Add ability to manually login with auth token, and decoupled shared singleton with internals#42
Open
mwaterfall wants to merge 3 commits intodevedup:masterfrom
Open
Add ability to manually login with auth token, and decoupled shared singleton with internals#42mwaterfall wants to merge 3 commits intodevedup:masterfrom
mwaterfall wants to merge 3 commits intodevedup:masterfrom
Conversation
This can be useful if multiple isolated instances of FlickrKit need to be used when managing multiple accounts in a single app.
…rsist token to user defaults with completing auth. This change does not affect normal use of FlickrKit and the default behavior is retained.
It conflicted with other install of Tony Million's Reachability (TMReachability)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow me to manage multiple Flickr accounts within one app, and removing any shared dependencies. The default behaviour has not been changed, and the only public changes are:
Allow someone to manually log in with their own token:
And disable persisting of auth token when completing auth, to allow someone to manually grab the tokens after auth is completed and store them how they wish: