Open
Conversation
…letion: Previously the permissionGranted attribute was set only in userAuthorizationURLWithRequestToken:requestedPermission:. But this method is only called by the initial authorization procedure (where the user is asked for permission) initiated by beginAuthWithCallbackURL:permission:completion:. It is not called when using checkAuthorizationOnCompletion:. This commit stores the grantedPermission attribute along with the auth token in the NSUserDefaults, and restores them when checkAuthorizationOnCompletion: succeeds.
… using stringForKey: and objectForKey: and removeObjectForKey:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
permissionGrantedattribute was set only inuserAuthorizationURLWithRequestToken:requestedPermission:. But this method is not called when usingcheckAuthorizationOnCompletion:. Thus, requests that require write or delete permission failed when using a token from a previous authentication procedure.This pull request stores the
grantedPermissionattribute along with the auth token in the NSUserDefaults, and restores it whencheckAuthorizationOnCompletion:succeeds.