fix(storage): increase default per-workspace PVC size from 5Gi to 10Gi

[rohanKanojia]

What does this PR do?

• Increase the default PVC size to 10Gi to accommodate resource requirements of JetBrains IDEs, preventing PVC provisioning errors.
• Update attributes of perWorkspace-storage test case that relied on calculated PVC size greater than default size (earlier default size was 5GiB, values were adding sum to slightly greater than 5GiB). With new 10GiB default size, increase volume sizes to match expectation.
• Update devworkspaceoperatorconfig godoc to reflect new size changes and regenerate CRDs.

What issues does this PR fix or reference?

Related to eclipse-che/che#23590 (per-workspace)

Old PR to bump common storage PVC Size #746

Is it tested? How?

With Changes

1. Checkout code changes added in this PR
2. Deploy DevWorkspace Operator Kubernetes/OpenShift cluster make docker && make install
3. Create DevWorkspace with per-workspace storage
4. Check PVC Size (should be 10GB)

oc create -f samples/per-workspace-storage.yaml             
devworkspace.workspace.devfile.io/code-latest-per-workspace created
 % oc get pvc                                       
NAME                                STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   VOLUMEATTRIBUTESCLASS   AGE
storage-workspaced9e40435ac9e447c   Bound    pvc-3ac6106d-cb4c-49ac-9f36-54cb57c98108   10Gi       RWO            stan

Without Changes

With current changes in main, when we create a DevWorkspace with per-workspace storage, the claim-devworkspace PVC Size is 5GB

oc create -f samples/per-workspace-storage.yaml
devworkspace.workspace.devfile.io/code-latest-per-workspace created
oc get pvc                                          
NAME                                STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   VOLUMEATTRIBUTESCLASS   AGE
storage-workspace0bf84003adfe4a28   Bound    pvc-66b71c2b-73df-484f-8dad-555f7a2a8fec   5Gi        RWO            standard       <unset>

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[rohanKanojia]

/ok-to-test

[dkwon17]

@rohanKanojia thank you for the PR,

I noticed that the default is mentioned in this comment:

devworkspace-operator/apis/controller/v1alpha1/devworkspaceoperatorconfig_types.go

Lines 259 to 260 in e0ed8d2

	// The default Persistent Volume Claim size for the "per-workspace" storage class.
	// If not specified, the "per-workspace" Persistent Volume Claim size is set to 5Gi

Could you please update it and regenerate the CRDs?

[rohanKanojia]

/retest

[dkwon17]

Thank you @rohanKanojia , could you please rebase against main? For some reason, I am having some build issues on my amd64 machine, I'm hoping the changes in #1500 will help

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, ibuziuk, rohanKanojia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dkwon17]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment