Issue 73/name conflict detection #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etection - Add fixture tests demonstrating current incorrect behavior (renames succeed when they should fail) - Add unit tests showing current VariableNameValidator only checks descendants, not parent scopes - Add explicit failing tests that demonstrate the expected behavior - Tests show rename operations incorrectly allow conflicts with variables in accessible parent scopes - Ready for green phase: implement parent scope checking in VariableNameValidator Note: Quality issues in test files are acceptable during red TDD phase
- Update rename command implementation and validation - Replace old test fixtures with cleaner structure - Add new test cases for parameter, parent scope, and same scope conflicts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Thanks for your PR! The build is failing due to a quality check. Otherwise the solution seems good and I'll merge it once the single use variables are inlined and the tests pass. |
…mand Eliminated 4 single-use variables in RenameCommand using RefakTS inline-variable: - sourceFile variable in execute method - node variable in execute method - transformation variable in performRename method - scope variable in validateNewName method This removes the file from quality baseline as all violations are now resolved. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
hehe oops, I just assumed that that was in my pre-commit hook :-). |
Owner
|
Thanks again! Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.