Fix error serialization in frontend notifications#123
Open
htrex wants to merge 1 commit intodevnen:mainfrom
Open
Fix error serialization in frontend notifications#123htrex wants to merge 1 commit intodevnen:mainfrom
htrex wants to merge 1 commit intodevnen:mainfrom
Conversation
Pydantic validation errors (HTTP 422) return `detail` as an array of objects, not a string. The frontend passed this directly to `new Error()`, which called `.toString()` on the array and displayed "[object Object]" to the user instead of the actual error message. Add `formatErrorDetail()` helper that handles all response formats: - String: returned as-is - Array (Pydantic 422): extracts `.msg` from each entry, joins with ";" - Object: falls back to JSON.stringify() Applied to all 4 error handling paths in script.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes frontend displaying
[object Object]instead of actual error messages when the backend returns validation errors.Problem
When the backend returns a Pydantic validation error (HTTP 422), the
detailfield is an array of objects, not a string:{ "detail": [ { "type": "less_than_equal", "loc": ["body", "chunk_size"], "msg": "Input should be less than or equal to 500", "input": 510 } ] }The frontend passed
errorResult.detaildirectly tonew Error(), which called.toString()on the array and displayed "[object Object]" to the user.Steps to reproduce
[object Object]in the error notificationSolution
Added a
formatErrorDetail()utility function that handles all API error response formats:HTTPException): returned as-is.msgfield from each entry and joins them with"; "JSON.stringify()Applied to all 4 error handling paths in
script.js:After fix
The error notification now correctly displays: "Input should be less than or equal to 500"
Test Plan