feat: 사용자 인증 Kafka 메시지 반영 기능 구현 by dev-ant · Pull Request #22 · devnogi/devnogi-auth-server

dev-ant · 2026-02-17T03:21:09Z

📋 상세 설명

배치 서버에서 카프카로 전송한 거대한 외침의 뿔피리 인증 메시지를 구독
- '메모노기_{인증값}' 형태의 메시지를 캐릭터명, 서버명, 만료 기간, 사용자ID를 검증하여 user 테이블을 자동 업데이트
user 테이블에 서버명, 인증여부 컬럼 추가
사용자 인증 관련 테이블 생성

📊 체크리스트

PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
코드가 테스트 되었나요
문서는 업데이트 되었나요
불필요한 코드를 제거했나요
이슈와 라벨이 등록되었나요

Copilot

Pull request overview

This PR implements a user verification system that integrates with Kafka to process verification events. The system allows users to generate verification tokens, which are validated when Kafka messages are received from a game server, linking in-game character identities to user accounts.

Changes:

Added database tables for user verification tokens, verification status, and verification history tracking
Implemented Kafka consumer to process verification events from game servers
Created REST API endpoints for token generation, retrieval, and verification status queries
Extended User entity with verification status fields and game server information

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 16 comments.

Show a summary per file

File	Description
V20260213110000__add_user_verification_tables.sql	Creates four new tables for user verification system with appropriate indexes and foreign key constraints
application-sample.yml	Adds Kafka consumer configuration and verification-related application properties
UserVerificationController.java	Provides REST endpoints for token management and verification status queries
UserVerificationVerifyMessage.java	Defines Kafka message structure for verification events
UserVerificationKafkaConsumer.java	Consumes and processes verification messages from Kafka topics
VerificationTokenStatus.java	Enum defining possible token states
VerificationFailureReason.java	Enum defining verification failure reasons
UserVerificationTokenRepository.java	JPA repository for token persistence with custom query methods
UserVerificationToken.java	Entity representing verification tokens with lifecycle methods
UserVerificationRepository.java	JPA repository for user verification summary data
UserVerificationHistoryRepository.java	JPA repository for verification attempt history
UserVerificationHistory.java	Entity tracking all verification attempts
UserVerification.java	Entity storing current verification status per user
UserVerificationTokenResponse.java	DTO for token information responses
UserVerificationTokenIssueResponse.java	DTO for token issuance responses
UserVerificationInfoResponse.java	DTO for user verification status information
UserVerificationHistoryResponse.java	DTO for individual verification history records
UserVerificationHistoryListResponse.java	DTO for paginated verification history
UserVerificationService.java	Core service implementing token generation, Kafka message processing, and verification logic
UserRepository.java	Adds nickname uniqueness check method
User.java	Extends entity with verification status and game profile fields
GlobalExceptionCode.java	Adds error codes for verification-related failures
UserUpdateConstant.java	Adds Kafka topic constant for verification events
KafkaListenerConfig.java	Enables Kafka listener functionality
docker-compose-local.yml	Adds local development Docker configuration with Kafka connectivity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-17T03:26:38Z

src/main/java/until/the/eternity/das/common/constant/UserUpdateConstant.java

 public class UserUpdateConstant {
  public static final String INFO = "USER_INFO_UPDATE_EVENT";
  public static final String PASSWORD = "PASSWORD_UPDATE_EVENT";
+  public static final String USER_VERIFICATION_VERIFY = "USER_VERIFICATION_VERIFY_EVENT";


The constant USER_VERIFICATION_VERIFY is defined but appears to duplicate the functionality of the kafka topic configuration. The constant name suggests it should match the topic name in application-sample.yml, but this creates a maintenance burden if the topic name changes. Consider either removing this constant and using the property directly, or using this constant consistently throughout the codebase instead of string literals in configuration.

Suggested change

public static final String USER_VERIFICATION_VERIFY = "USER_VERIFICATION_VERIFY_EVENT";

Copilot · 2026-02-17T03:26:39Z

src/main/java/until/the/eternity/das/verification/application/UserVerificationService.java

+    if ("oldest".equals(normalizedSort)) {
+      items = items.stream().collect(java.util.stream.Collectors.toList());
+      Collections.reverse(items);
+    }


The conversion from mutable to immutable list on line 114 is unnecessary and inefficient. The stream().toList() on line 111 already returns an immutable list. If the intention is to reverse the list, use a different approach such as creating the list directly as ArrayList or use Collections.reverse directly on a mutable copy created only when needed.

Copilot · 2026-02-17T03:26:39Z

src/main/java/until/the/eternity/das/verification/application/UserVerificationService.java

+    invalidatePreviousOwner(event.serverName(), event.characterName(), user.getId());
+
+    UserVerification verification = userVerificationRepository.findByUserId(user.getId())
+      .orElseGet(() -> UserVerification.builder().user(user).verificationCount(0).verified(false).build());
+
+    verification.markVerified(event.serverName(), event.characterName(), now, token.getId());
+    token.markVerified(now);
+
+    user.updateServerName(event.serverName());
+    user.updateVerificationStatus(true, now);


Race condition potential: When a character identity changes ownership from one user to another (lines 180-189), the invalidation of the previous owner and verification of the new owner are not done atomically within a single transaction. Although the method has @transactional, if two verification messages for the same character arrive simultaneously, it could lead to inconsistent state. Consider adding database-level locking (pessimistic locking) on the UserVerification record for the server/character combination to prevent race conditions.

Copilot · 2026-02-17T03:26:39Z

src/main/java/until/the/eternity/das/user/entity/User.java

+  public void updateGameProfile(String nickname, String serverName) {
+    this.nickname = nickname;
+    this.serverName = serverName;
+  }


The updateGameProfile method allows updating both nickname and serverName together, but there's no validation to ensure the nickname doesn't conflict with existing users. This could lead to duplicate nickname constraint violations. Consider adding validation or using the existsByNicknameAndIdNot method to check for conflicts before updating, or document that validation should be done by the caller.

Copilot · 2026-02-17T03:26:39Z

src/main/java/until/the/eternity/das/verification/application/UserVerificationService.java

+  private String toHex(byte[] bytes) {
+    StringBuilder builder = new StringBuilder(bytes.length * 2);
+    for (byte b : bytes) {
+      builder.append(String.format("%02X", b));
+    }
+    return builder.toString();
+  }


The toHex method converts bytes to uppercase hex strings (line 385), but many hex encoding conventions use lowercase. While this is not inherently wrong, consider documenting this choice or using lowercase for consistency with common hex encoding standards. This affects token values that are stored in the database and returned to users.

Copilot · 2026-02-17T03:26:41Z

src/main/java/until/the/eternity/das/user/entity/UserRepository.java

+  boolean existsByNicknameAndIdNot(String nickname, Long id);
+


The existsByNicknameAndIdNot method is added but not used anywhere in this PR. If this method is intended for future use or is part of another feature, it should be documented. Otherwise, consider removing it to keep the codebase clean.

Suggested change

boolean existsByNicknameAndIdNot(String nickname, Long id);

Copilot · 2026-02-17T03:26:41Z

docker-compose-local.yml

+      DB_PASSWORD: ${DB_PASSWORD:-devnogi0529!}
+      KAFKA_BOOTSTRAP_SERVERS: ${KAFKA_BOOTSTRAP_SERVERS:-119.194.235.11:9102}


The docker-compose file contains hardcoded sensitive information in plain text including database password 'devnogi0529!' on line 21 and Kafka bootstrap server IP address on line 22. Even for local development, credentials should not be hardcoded. These values should be moved to environment variables or a separate .env file that's not committed to version control.

Suggested change

DB_PASSWORD: ${DB_PASSWORD:-devnogi0529!}

KAFKA_BOOTSTRAP_SERVERS: ${KAFKA_BOOTSTRAP_SERVERS:-119.194.235.11:9102}

DB_PASSWORD: ${DB_PASSWORD}

KAFKA_BOOTSTRAP_SERVERS: ${KAFKA_BOOTSTRAP_SERVERS}

Copilot · 2026-02-17T03:26:41Z

src/main/java/until/the/eternity/das/user/entity/User.java

+
+  @Column(name = "is_verified", nullable = false)
+  @Comment("사용자 인증 상태")
+  private boolean verified;


The new verified field does not have a default value defined in the entity. Since the database migration uses DEFAULT FALSE, the entity should match this with @Builder.Default annotation to ensure consistency when creating User objects via builder pattern. Without this, new User instances created with the builder will have null for primitive boolean, which may cause issues.

Suggested change

private boolean verified;

@Builder.Default

private boolean verified = false;

Copilot · 2026-02-17T03:26:42Z

src/main/resources/db/migration/V20260213110000__add_user_verification_tables.sql

+    user_id BIGINT NULL COMMENT '회원 ID',
+    server_name VARCHAR(20) NULL COMMENT '서버명',
+    character_name VARCHAR(100) NULL COMMENT '캐릭터명',
+    verified_at DATETIME NOT NULL COMMENT '검증 처리 시각',
+    verification_success BOOLEAN NOT NULL COMMENT '인증 성공 여부',
+    failure_reason VARCHAR(100) NULL COMMENT '실패 사유',
+    token_id BIGINT NULL COMMENT '토큰 ID',
+    created_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT '생성 시각',
+    CONSTRAINT fk_user_verification_history_user_id FOREIGN KEY (user_id) REFERENCES users(id),


The foreign key constraint on user_id in user_verification_history allows NULL values (line 38), but the constraint on line 46 references users(id). In MySQL, a foreign key constraint on a nullable column will allow NULL values, but it's unusual to have verification history without knowing which user it belongs to. Consider whether user_id should be NOT NULL, or document the use case where user_id can be NULL (e.g., when token lookup fails).

src/main/resources/db/migration/V20260213110000__add_user_verification_tables.sql

dev-ant added 2 commits February 17, 2026 12:13

feat: 사용자 인증 정보 Kafka 메시지 수신 기능 구현

bd9d1b9

feat: docker-compose-local Kafka env 추가

91f0001

dev-ant requested a review from Copilot February 17, 2026 03:21

dev-ant self-assigned this Feb 17, 2026

dev-ant added the ✨feature 새로운 기능 추가 label Feb 17, 2026

Copilot started reviewing on behalf of dev-ant February 17, 2026 03:21 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

dev-ant merged commit 9858089 into dev Feb 17, 2026
8 checks passed

dev-ant deleted the feat/user-certification branch February 17, 2026 03:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: 사용자 인증 Kafka 메시지 반영 기능 구현#22

feat: 사용자 인증 Kafka 메시지 반영 기능 구현#22
dev-ant merged 2 commits intodevfrom
feat/user-certification

dev-ant commented Feb 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		DB_PASSWORD: ${DB_PASSWORD:-devnogi0529!}
		KAFKA_BOOTSTRAP_SERVERS: ${KAFKA_BOOTSTRAP_SERVERS:-119.194.235.11:9102}

	private boolean verified;
	@Builder.Default
	private boolean verified = false;

Comments

Conversation

dev-ant commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 상세 설명

📊 체크리스트

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dev-ant commented Feb 17, 2026 •

edited

Loading