perf: 경매장 거래 내역 검색 아이템명 완전 일치 여부 요청 파리미터 추가 및 인덱스 개선 by dev-ant · Pull Request #101 · devnogi/open-api-batch-server

dev-ant · 2026-02-19T03:53:07Z

📋 상세 설명

경매장 거래 내역 검색 아이템명 완전 일치 여부 (isExactItemName, Boolean, isRequired=false, defaultValue=false) 추가
- 다만 프론트엔드에서는 true를 기본값으로 사용하도록 권장할 거임
auction_history 테이블에 기존 인덱스 제거
- top_category, sub_category, item_name, data_auction_buy DESC 인덱스 추가

📊 체크리스트

PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
코드가 테스트 되었나요
문서는 업데이트 되었나요
불필요한 코드를 제거했나요
이슈와 라벨이 등록되었나요

github-actions · 2026-02-19T03:54:08Z

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

codecov · 2026-02-19T03:54:23Z

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../persistence/AuctionHistoryQueryDslRepository.java	0.00%	2 Missing ⚠️
...persistence/AuctionRealtimeQueryDslRepository.java	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR enhances auction history and realtime search functionality by adding an exact item name matching option and optimizing database indexes for better query performance.

Changes:

Added isExactItemName parameter to enable exact vs partial (LIKE) item name matching
Optimized auction history indexes by replacing idx_top_sub_item with idx_ah_top_sub_name_date and adding idx_ahio_type_history
Updated date examples in API documentation to reflect current dates

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
AuctionHistorySearchRequest.java	Added `isExactItemName` Boolean parameter for exact match option
AuctionRealtimeSearchRequest.java	Added `isExactItemName` Boolean parameter for exact match option
AuctionHistoryQueryDslRepository.java	Implemented conditional logic for exact vs LIKE search based on new parameter
AuctionRealtimeQueryDslRepository.java	Implemented conditional logic for exact vs LIKE search based on new parameter
V20__optimize_auction_history_search_indexes.sql	Replaced legacy index with optimized multi-column indexes
DateAuctionBuyRequest.java	Updated example dates to February 2026
AuctionHistoryServiceTest.java	Updated test to include new parameter in record construction
ItemInfoServiceTest.java	Code formatting improvements (line break adjustments)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-19T03:57:03Z

src/main/resources/db/migration/V20__optimize_auction_history_search_indexes.sql

+-- Equality filters first, range/sort column last
+-- date_auction_buy는 where 조건에 무조건 포함 및 높은 확률로 정렬 조건
+CREATE INDEX idx_ah_top_sub_name_date
+    ON auction_history (item_top_category, item_sub_category, item_name, date_auction_buy DESC);


The index includes item_name as an equality filter column, but the query logic uses containsIgnoreCase (LIKE search) when isExactItemName is false or null. This means the index may not be effective for the common case of LIKE searches.

Consider either:

Creating separate indexes for exact vs LIKE searches

Moving item_name after date_auction_buy in the index so it doesn't break the index effectiveness for range/sort operations

Adding a covering index without item_name for LIKE searches

The current index will only be fully effective when isExactItemName=true, but may have reduced effectiveness for LIKE searches since MySQL/PostgreSQL cannot use the full index when a prefix column uses LIKE patterns.

Suggested change

ON auction_history (item_top_category, item_sub_category, item_name, date_auction_buy DESC);

ON auction_history (item_top_category, item_sub_category, date_auction_buy DESC, item_name);

Copilot · 2026-02-19T03:57:03Z

...the/eternity/auctionhistory/infrastructure/persistence/AuctionHistoryQueryDslRepository.java

+            if (Boolean.TRUE.equals(c.isExactItemName())) {
+                builder.and(ah.itemName.eq(c.itemName()));
+            } else {
+                builder.and(ah.itemName.containsIgnoreCase(c.itemName()));
+            }


The new isExactItemName parameter lacks test coverage. While the test correctly adds a seventh null parameter to match the new record signature, there are no tests verifying the behavior when isExactItemName is true vs false vs null.

Consider adding test cases that verify:

When isExactItemName=true, only exact matches are returned

When isExactItemName=false or null, partial matches (LIKE) are returned

The query correctly handles the parameter in combination with other search criteria

Copilot · 2026-02-19T03:57:04Z

...e/eternity/auctionrealtime/infrastructure/persistence/AuctionRealtimeQueryDslRepository.java

+            if (Boolean.TRUE.equals(c.isExactItemName())) {
+                builder.and(ar.itemName.eq(c.itemName()));
+            } else {
+                builder.and(ar.itemName.containsIgnoreCase(c.itemName()));
+            }


The new isExactItemName parameter lacks test coverage. There are no tests verifying the behavior when isExactItemName is true vs false vs null.

Consider adding test cases that verify:

When isExactItemName=true, only exact matches are returned

When isExactItemName=false or null, partial matches (LIKE) are returned

The query correctly handles the parameter in combination with other search criteria

dev-ant added 4 commits February 19, 2026 12:33

feat: 경매장 검색 시 아이이템명 완전 일치 여부 파라미터 추가

17f7620

feat: 경매장 거래 내역 검색 일자 sample 값 수정

a8d6ca3

fix: V20 flyway script 주석 추가

a8865c1

fix: optimize imports

53f15ab

dev-ant requested a review from Copilot February 19, 2026 03:53

dev-ant self-assigned this Feb 19, 2026

dev-ant added the ✨feature 새로운 기능 추가 label Feb 19, 2026

Copilot started reviewing on behalf of dev-ant February 19, 2026 03:53 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

dev-ant merged commit e1b8810 into dev Feb 19, 2026
7 of 8 checks passed

dev-ant deleted the perf/auction-history-index branch February 19, 2026 03:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

perf: 경매장 거래 내역 검색 아이템명 완전 일치 여부 요청 파리미터 추가 및 인덱스 개선#101

perf: 경매장 거래 내역 검색 아이템명 완전 일치 여부 요청 파리미터 추가 및 인덱스 개선#101
dev-ant merged 4 commits intodevfrom
perf/auction-history-index

dev-ant commented Feb 19, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

codecov bot commented Feb 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Copilot AI Feb 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	ON auction_history (item_top_category, item_sub_category, item_name, date_auction_buy DESC);
	ON auction_history (item_top_category, item_sub_category, date_auction_buy DESC, item_name);

Comments

Conversation

dev-ant commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 상세 설명

📊 체크리스트

Uh oh!

github-actions bot commented Feb 19, 2026

✅ 테스트 결과 for PR

Uh oh!

codecov bot commented Feb 19, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dev-ant commented Feb 19, 2026 •

edited

Loading