Skip to content

Comments

feat: 동기화 및 배치 실행 API PreAuthorize 구현#102

Merged
dev-ant merged 3 commits intodevfrom
feat/preauthorize-api
Feb 19, 2026
Merged

feat: 동기화 및 배치 실행 API PreAuthorize 구현#102
dev-ant merged 3 commits intodevfrom
feat/preauthorize-api

Conversation

@dev-ant
Copy link
Contributor

@dev-ant dev-ant commented Feb 19, 2026

📋 상세 설명

  • 동기화 및 배치 실행 API 관리자 권한 검증 위해 PreAuthorize Annotation 추가

📊 체크리스트

  • PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
  • 코드가 테스트 되었나요
  • 문서는 업데이트 되었나요
  • 불필요한 코드를 제거했나요
  • 이슈와 라벨이 등록되었나요 이슈 미등록

@dev-ant dev-ant requested a review from Copilot February 19, 2026 11:58
@dev-ant dev-ant self-assigned this Feb 19, 2026
@dev-ant dev-ant added the ✨feature 새로운 기능 추가 label Feb 19, 2026
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../the/eternity/common/filter/GatewayAuthFilter.java 0.00% 12 Missing ⚠️
...java/until/the/eternity/common/enums/UserRole.java 0.00% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


// Gateway에서 전달한 인증 헤더 읽기
String userIdHeader = request.getHeader("X-Auth-User-Id");
String usernameHeader = request.getHeader("X-Auth-Username");
Copy link

Copilot AI Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usernameHeader variable is read from the request but never used after the refactoring. It's only referenced in the debug log on line 62, but it's not passed to the getAuthentication method anymore. Consider removing this unused variable to improve code clarity, or if it's needed for logging purposes, document that explicitly.

Copilot uses AI. Check for mistakes.
@dev-ant dev-ant changed the title feat/preauthorize api feat: 동기화 및 배치 실행 API PreAuthorize 구현 Feb 19, 2026
@dev-ant dev-ant merged commit 47a4677 into dev Feb 19, 2026
7 of 8 checks passed
@dev-ant dev-ant deleted the feat/preauthorize-api branch February 19, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feature 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant