Open
Conversation
Author
|
Updated PR to also test with python3.7. Looks like the Travis build failed on the first commit due to a transient dependency issue, which is now resolved. |
Author
|
@fschulze Do you need anything else added or changed in this PR before it can be merged? |
Contributor
|
@00willo time to look at it. I hope to get to it next week. Thanks! |
Contributor
|
Work on devpi-ldap was very low priority for a while, so I only got to look at this now. This PR looks very useful, but the code base has changed a bit in the meantime. Would you still be interested in rebasing and updating this PR? If so, it would be nice to have some tests for the added conditions in the connection setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure appropriate flags are set on ldap3.Connection object based on the following:
ldapsis specified inurlconfig option, ie ldaps on port 636