Fix Selenium screenshot cropping issue by retrying with larger height#129
Open
Archkik wants to merge 1 commit intodexplo:masterfrom
Open
Fix Selenium screenshot cropping issue by retrying with larger height#129Archkik wants to merge 1 commit intodexplo:masterfrom
Archkik wants to merge 1 commit intodexplo:masterfrom
Conversation
Collaborator
|
Thanks for contribution, I think it is a nice idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some environments, the hardcoded
+90height buffer used inset_window_size()is insufficient to capture the entire table, resulting in the bottom portion of the image being cut off.This PR adds a simple retry mechanism: