Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the basemap/overlay system to support TileJSON-based sources (including remote TileJSON URLs) and refactors the basemap schema to separate type-specific fields into dedicated tables.
Changes:
- Added UI support for a new “TileJSON” overlay/basemap entry mode and a read-only TileJSON details view.
- Updated basemap backend routes/models/types to accommodate the schema split (vector/raster/terrain tables) and a new
tilejsonfield. - Adjusted test fixtures to align with updated nullability for
iconset/attribution.
Reviewed changes
Copilot reviewed 17 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| api/web/src/components/util/PublicTilesSelect.vue | Adds selected-tile fetching based on incoming url prop and annotates selected items with a url field. |
| api/web/src/components/Admin/TileJSONView.vue | New component to display TileJSON-derived source details. |
| api/web/src/components/Admin/AdminOverlaysEdit.vue | Adds “TileJSON” mode, fetches TileJSON metadata into the form, and reorganizes overlay editing around per-mode basemap objects. |
| api/routes/profile-overlays.ts | Updates snapping availability checks and adds stricter mode_id handling for basemap/overlay modes. |
| api/routes/config.ts | Tightens TypeScript typing for key inclusion checks. |
| api/routes/basemap.ts | Adds URL parse error handling for TileJSON import, updates snapping filtering logic, and adds support for tilejson in schemas/responses. |
| api/test/*.srv.test.ts | Updates expected request/response fields to use null instead of empty strings for nullable fields. |
| api/lib/schema.ts | Splits basemap type-specific fields into basemaps_vector, basemaps_raster, and basemaps_terrain tables; adds tilejson to basemaps. |
| api/lib/models/Basemap.ts | Implements create/read/update logic across the new per-type tables and updates list/collections queries. |
| api/lib/types.ts | Reworks BasemapResponse shape to match the refactored model/schema. |
| api/migrations/* | Adds new tables and introduces the tilejson column. |
| api/package-lock.json | Bumps package version. |
Files not reviewed (1)
- api/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context