Feature to disable add files button#132
Open
anmol1707 wants to merge 5 commits intodharness:masterfrom
Open
Conversation
added 2 commits
August 22, 2019 22:36
…n the input bar. Defaults to true.
added 3 commits
August 23, 2019 16:34
| </div> | ||
| ); | ||
| } else { | ||
| return null; |
Contributor
There was a problem hiding this comment.
Hm so this makes the emoji picker icon jump to the left whenever the user starts typing; I think it would be better to always render either the file picker or the send icon. The handler _submitText already just ignores empty messages so I think it would be fine.
Contributor
heatherbooker
left a comment
heatherbooker
left a comment
There was a problem hiding this comment.
This looks great! Just the one rendering detail that I'd like to be changed before merging. Thanks so much for your contribution!
| @@ -1,5 +1,6 @@ | |||
| coverage/ | |||
| demo/dist/ | |||
| .idea/ | |||
Contributor
There was a problem hiding this comment.
Could we maybe put this after the .DS_Store entry, and give that section a title like # OS or editor files?
skipmumba
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a prop that decides whether or not to show the add files button in the input bar.
Closes #134.
Checklist
npm start) to ensure it still functions as expected, and/ornpm run lintpasses (npm run lint -- --fixwill autofix where possible)