Skip to content

Conversation

@eirikbacker
Copy link
Contributor

@eirikbacker eirikbacker commented Dec 17, 2025

Summary

  • Resolves Clickable table rows #3348
  • Question: Should the data-clickable attribute be moved to the tr and contain a selector? 🤔
    • Example: <tr data-clickable="input"> or <tr data-clickable="button:last-child">
    • Pros:
      • Works without relying on class names, meaning the same function deal with both tr, card and more
      • Might be a bit more explicit as we put the attribute on the element that gets enhanced
      • Easy-to-read CSS selectors (tr[data-clickable]:hover)
    • Cons:
      • Really hard to avoid :hover when hovering other interactive child elements that are not the clickable-trigger

Checks

@eirikbacker eirikbacker self-assigned this Dec 17, 2025
@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

⚠️ No Changeset found

Latest commit: 34504f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Preview deployments for this pull request:

storybook - 30. Dec 2025 - 12:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clickable table rows

2 participants