Conversation
Updated from branch reference to published version containing CDN migration changes. Related to DOSTM-8643
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how tool filenames are handled, especially for tools whose CDN and local filenames differ. It introduces helper functions to consistently resolve the correct filenames, updates the download logic to use these helpers, and changes the tool download URL and API prefix to match new requirements. Additionally, the dependency on
@digicert/ssm-client-tools-installeris bumped to version 1.6.0.Filename handling improvements:
getLocalFileNameandgetCdnFileNamehelper functions to resolve tool filenames, supporting tools with different CDN and local filenames. Updated all relevant logic to use these helpers instead of directly accessingtoolDownloaded. (build/index.js) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Download logic and API changes:
build/index.js) [1] [2]build/index.js) [1] [2]Dependency updates:
@digicert/ssm-client-tools-installerdependency from version 1.5.0 to 1.6.0. (package.json)