Async track fetching when selecting playlist. #971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes Dopamine freezing when selecting a playlist with many tracks, or with tracks in a location which takes a significant time to read. For example, if a file from the playlist is in an unavailable network drive, Dopamine completely freezes for approximately 2.5s.
The cause of the freezing is
fs.existsSync()viaPlaylistService.getTracksAsync()->PlaylistService.decodePlaylistAsync()->FileValidator.isPlayableAudioFile().Fix uses async method
fs.access()instead of the blockingfs.existsSync().Note that this also means that other functions reliant on
FileValidator.isPlayableAudioFile()will also freeze Dopamine in a similar case, so it is potentially worth swapping those to a different method as well.