Move creating /tmp out of other directories#6490
Open
AmitPhulera wants to merge 1 commit intomasterfrom
Open
Conversation
since this option is configured in java.opts and is recently added so if anyone who will update the config might face issue after es restarts. The commit creates another task and tags it as es_conf to ensure that the directory mentioned in jvm.opts exists
millerdev
approved these changes
Mar 13, 2025
| - "{{ elasticsearch_data_dir }}" | ||
| - "{{ elasticsearch_data_dir }}/data" | ||
| - "{{ elasticsearch_data_dir }}/logs" | ||
| - "{{ elasticsearch_data_dir }}/tmp" |
Contributor
There was a problem hiding this comment.
Curious why the es_conf tag was not added to this task? Does the conf file not reference data and logs directories?
Contributor
Author
There was a problem hiding this comment.
I want just thinking about java options file and we recently updated 🤔
I guess having it here would also make sense since it can also be updated by updating es_conf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this option is configured in
java.optsand is recently changed so if anyone who will update the config might face issue after es restarts. The commit creates another task and tags it ases_confto ensure that the directory mentioned injvm.optsexists