Open
Conversation
snopoke
approved these changes
Dec 9, 2021
Contributor
snopoke
left a comment
snopoke
left a comment
There was a problem hiding this comment.
A few tests would be great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New optimization for the xpath engine.
Naively identifies the predicate pattern
X or YorX and Ywhen X and Y are both indexed lookups, and performs the lookup by doing both indexed lookups independently against their index, then performing the appropriate action on the results.
Only implemented on Formplayer initially, since on FormPlayer the indexed lookups are so fast that there are very, very few situations in which this isn't the optimal query path. On Android, it would be important to check the evaluation context first to ensure that the set being evaluated isn't very small.