Minor formatting suggestions#109
Open
jmjatlanta wants to merge 1 commit intodimxy:dimxy-fix-staking-arrayfrom
Open
Minor formatting suggestions#109jmjatlanta wants to merge 1 commit intodimxy:dimxy-fix-staking-arrayfrom
jmjatlanta wants to merge 1 commit intodimxy:dimxy-fix-staking-arrayfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes made in dimxy-fix-staking-array are very good and IMO necessary. Making C-style arrays using malloc/calloc is not something I would recommend to anyone in C++.
The fixes in this PR change no functionality. They only
arraytocollection. The word "array" to me puts the wrong idea into my head as to what the object truly is. "Collection" is a bit more generic IMO.These changes just make the code easier to read IMO. Merge this branch into yours if you wish.