Open
Conversation
Only those that use chainActive
…ShutdownRequested
1. _COINBASE_MATURITY+10 -> Params().CoinbaseMaturity()+10 substitution suggested by author was bit incorrect, bcz _COINBASE_MATURITY == 100 at any time and Params().CoinbaseMaturity() depends on chain (for KMD it's 100, for ACs it's 1) and assertion was wrong. 2. Introducing maxWitnessCacheSize CWallet member and fill it's default value in c'tor made c'tors bit "ambiguously" and probably was not a best idea.
to avoid the following errors: /usr/bin/ld: depends/x86_64-unknown-linux-gnu/lib/libgmp.a(invert_limb.o): warning: relocation against `__gmpn_invert_limb_table' in read-only section `.text' /usr/bin/ld: warning: creating DT_TEXTREL in a PIE when build with 11.2.0 (Ubuntu 22.04.1 LTS, etc.)
Issue: if we will try to build KomodoOcean with CXXFLAGS='-g -O0'
we will get the following error during linkage:
usr/bin/ld: libbitcoin_util.a(libbitcoin_util_a-util.o): in function `__static_initialization_and_destruction_0(int, int)':
/home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nStakedDecemberHardforkTimestamp'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS4Timestamp'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS5Timestamp'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS6Timestamp'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nDecemberHardforkHeight'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS4HardforkHeight'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS5HardforkHeight'
/usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS6HardforkHeight'
So, we need to include komodo_hardfork.cpp into libbitcoin_util_a_SOURCES
or delete include of komodo_hardfork.h from komodo_globals.h.
because of error: free(): double free detected in tcache 2 Aborted (core dumped) TODO: fix this test.
* fix function(s) invokations after inaccurate merge branches * fix treating std as a label, name it's a variable of std::string type
more pegs, hush, marmara code removed
add interest calculations via CCoinsViewCache::GetValueIn test
Combined PR for jmj refactoring
add z_gettreestate rpc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.