Skip to content

[fix][runtime] The concat function supports composite types #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubgxll merged 1 commit into from
Jan 6, 2026
Merged

[fix][runtime] The concat function supports composite types #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions runtime/src/main/java/io/dingodb/expr/runtime/op/string/ConcatFun.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,30 @@
import io.dingodb.expr.common.type.Type;
import io.dingodb.expr.common.type.Types;
import io.dingodb.expr.runtime.ExprConfig;
import io.dingodb.expr.runtime.op.BinaryOp;
import io.dingodb.expr.runtime.op.OpKey;
import io.dingodb.expr.runtime.op.OpKeys;
import io.dingodb.expr.runtime.op.VariadicOp;
import org.checkerframework.checker.nullness.qual.NonNull;

import java.io.Serial;

public class ConcatFun extends VariadicOp {
public static final String NAME = "CONCAT";
public static final ConcatFun INSTANCE = new ConcatFun();

private static final long serialVersionUID = 5454356467741754567L;
public static final String NAME = "CONCAT";

//@Override
public Object evalValue(Object value0, Object value1, ExprConfig config) {
if (value0 == null || value1 == null) {
return null;
}
return String.valueOf(value0) + value1;
}
@Serial
private static final long serialVersionUID = -6456730710140240892L;

@Override
protected Object evalNonNullValue(@NonNull Object[] value, ExprConfig config) {
public Object evalValue(Object @NonNull [] values, ExprConfig config) {
StringBuilder stringBuilder = new StringBuilder();
for (Object valueItem : value) {
stringBuilder.append(valueItem);
for (Object value : values) {
if (value == null) {
return null;
} else {
stringBuilder.append(value);
}
}
return stringBuilder.toString();
}
Expand All @@ -53,12 +53,12 @@ protected Object evalNonNullValue(@NonNull Object[] value, ExprConfig config) {
}

@Override
public Type getType() {
return Types.STRING;
public OpKey keyOf(@NonNull Type @NonNull ... types) {
return OpKeys.ALL_STRING.keyOf(types);
}

@Override
public OpKey keyOf(@NonNull Type @NonNull ... types) {
return null;
public Type getType() {
return Types.STRING;
}
}