Finish current challenge before starting the latest one#17
Open
Finish current challenge before starting the latest one#17
Conversation
dermetfan
force-pushed
the
fix-challenge-cancellation
branch
from
642fea9 to
c31109b
Compare
Handle donation before mining (simplifies code)
dermetfan
force-pushed
the
fix-challenge-cancellation
branch
from
c31109b to
041b0c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a new challenge is found, mining for the current one is stopped.
This is becoming a problem for lower hash rate miners as difficulty increases, since they might not be able to solve a challenge within one hour, so before a new one becomes available, and hence solving is always canceled before a solution could be found.
With this PR, the newest available challenge is started only after the previous one is solved.
To simplify the code, this also handles donation before starting a mining cycle. There is no point in delaying donation until after a solution was found — the API supports donation as long as the addresses are registered and the documentation even includes an example reply for that case.