Fix minor bug in the login workflow #2144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalaska
added
API
This was
linked to
issues
Mar 18, 2021
npalaska
force-pushed
the
login_workflow_fixes
branch
2 times, most recently
from
c42fbda to
e12844c
Compare
portante
requested changes
Mar 19, 2021
dbutenhof
reviewed
Mar 19, 2021
webbnh
previously approved these changes
Mar 19, 2021
npalaska
force-pushed
the
login_workflow_fixes
branch
from
312682c to
da98db0
Compare
dbutenhof
previously approved these changes
Mar 22, 2021
portante
reviewed
Mar 23, 2021
portante
requested changes
Mar 23, 2021
dbutenhof
previously approved these changes
Mar 23, 2021
npalaska
force-pushed
the
login_workflow_fixes
branch
from
434397d to
7045ff7
Compare
portante
previously approved these changes
Mar 24, 2021
dbutenhof
requested changes
Mar 24, 2021
npalaska
force-pushed
the
login_workflow_fixes
branch
from
c79c54c to
38dea5f
Compare
webbnh
previously approved these changes
Mar 25, 2021
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
GitHub didn't note anything changed in this latest round from the previous round, and neither did I. So, I've no reason not to approve.
However, I am left wondering whether maybe something you intended to commit didn't make it in (like a change to users_api.py line 397, for instance?).
dbutenhof
previously approved these changes
Mar 25, 2021
portante
requested changes
Mar 25, 2021
Member
portante
left a comment
portante
left a comment
There was a problem hiding this comment.
Looks good, just needs a rebase.
npalaska
force-pushed
the
login_workflow_fixes
branch
from
38dea5f to
37cc5fe
Compare
dbutenhof
previously approved these changes
Mar 26, 2021
webbnh
approved these changes
Mar 26, 2021
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
I don't see any changes...was this just a rebase?
webbnh
previously approved these changes
Mar 26, 2021
Member
webbnh
left a comment
webbnh
left a comment
There was a problem hiding this comment.
I don't see any changes...was this just a rebase?
Member
Author
|
yeah just a rebase |
npalaska
force-pushed
the
login_workflow_fixes
branch
from
37cc5fe to
29861a2
Compare
portante
approved these changes
Mar 26, 2021
webbnh
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if the authorization header is present during the login request (An attempt at creating another login token) we check the generated auth token with the one in the header. This check is redundant since we already check for the
integrityErroron authorization tokens.This PR: