Improved part search #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 3 column effect and section headers because they conflict with searching, sorting, and the built-in search inverse and sort inverse. It also makes it possible to read the entire name without hovering, which is necessary to distinguish several common objects. Improve part search: Search key now includes category, object name, and display name in search text. Input search can be several words, each of which is required individually (so things like "wall conc" or "unlock crate" or "decal 7"). Alphabetical sorting works properly (based on display name).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One bugfix (I think the old code was harmless, just named something "compact" while implying it was choosing a template_list style due to wrong argument order)
The second part is a major change to how part selection works, which I like a lot, but may not be your preference.