Open
Conversation
|
Thanks for making a start on this! IMO this would be better named |
Owner
|
Yep, I agree that |
|
what about |
Owner
|
Yep, -ize definitely the preferred spelling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for opening a PR directly, but this was simple enough that it would be easier to explain it with an actual example.
This is an attempt at solving the issue described in djrobstep/schemainspect#33. I'm adding an
--ignore-newlinesoption as suggested by @djrobstep, which is propagated down to the function comparison function (done by djrobstep/schemainspect#37).I'm willing to improve the PR, if you wish to follow this route.