Skip to content

Add --ignore-newlines option#105

Open
pferreir wants to merge 1 commit intodjrobstep:masterfrom
pferreir:add-ignore-newlines
Open

Add --ignore-newlines option#105
pferreir wants to merge 1 commit intodjrobstep:masterfrom
pferreir:add-ignore-newlines

Conversation

@pferreir
Copy link

@pferreir pferreir commented Dec 10, 2019

I apologize for opening a PR directly, but this was simple enough that it would be easier to explain it with an actual example.
This is an attempt at solving the issue described in djrobstep/schemainspect#33. I'm adding an --ignore-newlines option as suggested by @djrobstep, which is propagated down to the function comparison function (done by djrobstep/schemainspect#37).

I'm willing to improve the PR, if you wish to follow this route.

@gregplaysguitar
Copy link

Thanks for making a start on this! IMO this would be better named --normalise-newlines, since newlines are still significant to the comparison, they're just normalised to a standard entity.

@djrobstep
Copy link
Owner

Yep, I agree that normalise is more accurate as a description

@ThiefMaster
Copy link

what about normalize? I think in almost all other programs CLI options use the en_US versions, so users are likely to get it wrong if migra expects en_GB

@djrobstep
Copy link
Owner

Yep, -ize definitely the preferred spelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants