Make testing easier with docker#184
Open
provokateurin wants to merge 1 commit intodjrobstep:masterfrom
provokateurin:feature/docker-testing
Open
Make testing easier with docker#184provokateurin wants to merge 1 commit intodjrobstep:masterfrom provokateurin:feature/docker-testing
provokateurin wants to merge 1 commit intodjrobstep:masterfrom
provokateurin:feature/docker-testing
Conversation
Owner
|
Hi there, thanks so much for submitting this PR, and sorry it's taken so long to get to reviewing. I stepped away from active maintainer duties for a while but have now returned. The test setup is definitely a bit crufty and needs improving. However, one problem is that everybody does things slightly differently - I'm wary of embedding docker-specific stuff into the basic test commands. Let me have a think about how we can best arrange the tests to have a simple setup, and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180