Open
Conversation
pauldraper
force-pushed
the
pauldraper/comment
branch
from
5787dcd to
17a32d4
Compare
|
Thanks for doing this @pauldraper. We use migra and we also use comments, so this gets a 👍 from me! |
|
This will break if the comment has a single quote in it. Is there a way the string can be escaped when templating? |
|
@pauldraper @djrobstep , it'd be great to have this and djrobstep/migra#45 in master. Anything I can do to help get them across the finish line? |
joshainglis
reviewed
Jul 5, 2022
|
|
||
| @property | ||
| def create_statement(self): | ||
| return "comment on {} {} is '{}';".format( |
There was a problem hiding this comment.
Suggested change
| return "comment on {} {} is '{}';".format( | |
| return "comment on {} {} is $cmt${}$cmt$;".format( |
Might be worth using dollar quoting to allow unescaped ' in the comment
djrobstep
force-pushed
the
master
branch
3 times, most recently
from
13f62b5 to
ebbc2e4
Compare
|
Thanks for creating this PR. We are very interested in having this feature in migra so that we can use it with Hasura which makes great use of comments against the database schema. Is there anything we can help to get this PR across the finish line? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #14 but with tests