Properly create triggers with status other than the default "origin".#73
Open
martsberger wants to merge 3 commits intodjrobstep:masterfrom
Open
Properly create triggers with status other than the default "origin".#73martsberger wants to merge 3 commits intodjrobstep:masterfrom
martsberger wants to merge 3 commits intodjrobstep:masterfrom
Conversation
added 3 commits
October 4, 2021 17:04
… it from being included with triggers on views.
Owner
|
Hi there, thanks so much for submitting this PR, and sorry it's taken me a while to getting to review. All looks great apart from a couple of minor typos, I fixed them up and put them in a new PR here (#75) would you mind taking a look and confirming it looks fine and then I'll merge it! |
djrobstep
force-pushed
the
master
branch
3 times, most recently
from
13f62b5 to
ebbc2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default status for a trigger is "origin" and the create_statement will create this type of trigger just fine. For the other three types "disabled", "replica", and "always" the create statement needs to be followed by an alter table statement setting the proper trigger type.
Fixes this issue in migra djrobstep/migra#172