include defaults in create function signature#79
Open
joshainglis wants to merge 1 commit intodjrobstep:masterfrom
Open
include defaults in create function signature#79joshainglis wants to merge 1 commit intodjrobstep:masterfrom
joshainglis wants to merge 1 commit intodjrobstep:masterfrom
Conversation
djrobstep
force-pushed
the
master
branch
3 times, most recently
from
13f62b5 to
ebbc2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed when altering the default value of a function parameter that migra didn't pick up that there had been a change.
This was due to only using
pg_get_function_identity_arguments()for the signature, which does not include defaults.This change adds an extra column to the
functions.sqlquery to getpg_get_function_arguments(p.oid) as function_argumentswhich is then used as the signature for the create function statement. We still use the identity arguments for dropping the function.