dkms: read_conf: declare control var of a loop as local (fixes #565) #566
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject#565) It was spilling out to callers causing unpredictable behaviors.
Collaborator
|
Good catch. Please fix them all ;-) |
Member
|
Yes please! Thanks. |
Member
|
@morgwai any chance you can work on the others? |
Author
|
@scaronni apologies for the delay with this: something unexpected happened that keeps me extremely busy currently. I hope I will be able to work on this sometime next week. Please decide if in this situation you want to merge this single fix first and I would create a separate PR for others, or if you prefer to have them all bundled in this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial, but nasty...
There are other for-loops with non-local control vars around: please let me know if I should fix them all on this PR or keep it limited to the fix.