Use const instead of immutable for compatibility with new libdparse#805
Closed
Hackerpilot wants to merge 1 commit intomasterfrom
Closed
Use const instead of immutable for compatibility with new libdparse#805Hackerpilot wants to merge 1 commit intomasterfrom
Hackerpilot wants to merge 1 commit intomasterfrom
Conversation
Member
|
hm I'm not quite sure how these changes are related to the token structure changes. Did including the const arrays make it impossible to be immutable? In this case would changing in libdparse to be the needed fix? The appender data is dup'd anyway, it could probably be changed to idup without issues. |
WebFreak001
added a commit
to WebFreak001/libdparse
that referenced
this pull request
Apr 28, 2020
Fixes immutable assignment of tokens to variables (See dlang-community/D-Scanner#805)
WebFreak001
requested changes
Apr 28, 2020
Member
WebFreak001
left a comment
There was a problem hiding this comment.
fixing it here isn't the right approach imo, I submitted a PR to libdparse to fix it there instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the libdparse token changes weren't as backwards-compatible as we hoped. See #799 (comment)