Also generate ctor calltips for Struct/Class symbols with a callTip#662
Closed
RUSShyTwo wants to merge 1 commit intodlang-community:masterfrom
RUSShyTwo:patch-4
Closed
Also generate ctor calltips for Struct/Class symbols with a callTip#662RUSShyTwo wants to merge 1 commit intodlang-community:masterfrom RUSShyTwo:patch-4
RUSShyTwo wants to merge 1 commit intodlang-community:masterfrom
RUSShyTwo:patch-4
Conversation
WebFreak001
reviewed
Dec 5, 2021
Member
WebFreak001
left a comment
WebFreak001
left a comment
There was a problem hiding this comment.
is the constructor stuff really the only thing that changes? Do the opIndex/opCall things still work with the new change?
I haven't fully understood the new changes yet but it looks like it may be better to just remove the symbols[0].callTip is null check in the parent if here, to make the entire block be evaluated, now that all callTips have content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed because of this PR: dlang-community/dsymbol#175
Since it'll set the callTip for struct/class, this logic must be updated to take that into account