replace deprecated IO::CaptureOutput with Capture::Tiny, and cleanup IPC::Open3#45
Open
iynehz wants to merge 2 commits intodmgerman:masterfrom
iynehz:capture
Open
replace deprecated IO::CaptureOutput with Capture::Tiny, and cleanup IPC::Open3#45iynehz wants to merge 2 commits intodmgerman:masterfrom iynehz:capture
iynehz wants to merge 2 commits intodmgerman:masterfrom
iynehz:capture
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO::CaptureOutput is deprecated and the author recommends Capture::Tiny which is widely used in the Perl community today. See also https://metacpan.org/pod/IO::CaptureOutput#DESCRIPTION
And IPC::Open3 is actually not used in the code, so I would suggest completely remove it.