Open
Conversation
… into ctor; improve cjson decode error message
Contributor
Author
|
@yuyiguo did you have time to review this PR? I'm using it for dbs2go tests and it allows to use different DBS URLs in unit tests. |
Member
|
Valentin, Can we hold this if you already ran the unit tests against das2go? |
Contributor
Author
|
sure, I only pinged since there were no replies from you on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yuyiguo , here is patch of DBS client unit tests as well as some improvements to the DBS client. All of these changes I used to be able to run python client unittest suit to test dbs2go implementation.