Adjust codebase to work with plain or gzipped request body payloads#648
Open
vkuznet wants to merge 1 commit intodmwm:masterfrom
Open
Adjust codebase to work with plain or gzipped request body payloads#648vkuznet wants to merge 1 commit intodmwm:masterfrom
vkuznet wants to merge 1 commit intodmwm:masterfrom
Conversation
Contributor
Author
|
@yuyiguo , @amaltaro , @klannon , @KatyEllis I suggest that you take this PR into consideration as it can significantly improve our usage of DBS APIs and reduce latency related to large payloads. The changes are for DBS Writer, but once it is deployed, the other changes will be required to the clients, like WMAgent which should start adopting gzipped payloads and make adjustment to DBS POST API usage. I provided an example of how client should use HTTP request and it should be trivial to implement this in DMWM since it will only require to add extra HTTP header and start using gzip for payloads. |
Member
|
@vkuznet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to DBSWriterModel to enable gzip payload reads. I adjusted the codebase to work with both types of payloads, the current one (plain) and gzipped payloads.
The gzipped payload can be supplied in HTTP request by using "Content-Encoding: gzip" header, e.g.
Once this code will be in place the DBS clients, like WMAgent, etc. can start supplying gzipped payloads to DBS POST APIs, like bulkblocks, blocks, files, datasets, etc.
The proposed changes are compatible with both 2.X and 3.X python versions, and fully support current mode of operations (without gzip) for payloads.