Delete operation should only delete attributes which exist in the dictionary#661
Open
vkuznet wants to merge 1 commit intodmwm:masterfrom
Open
Delete operation should only delete attributes which exist in the dictionary#661vkuznet wants to merge 1 commit intodmwm:masterfrom
vkuznet wants to merge 1 commit intodmwm:masterfrom
Conversation
Contributor
Author
|
@amaltaro , I would like you to have a look at this PR as I want to make Python migration server compatible with new Go-based server where |
amaltaro
reviewed
Jul 28, 2022
Contributor
amaltaro
left a comment
amaltaro
left a comment
There was a problem hiding this comment.
Valentin, I didn't read all the discussion that you pointed out.
However, to me your change doesn't affect any behavior and it will actually have a safer key deletion. I left a suggestion in the code though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides an additional check before deleting certain attributes in file parent dictionaries which may be omitted in the output of
blockdumpsAPI. In particular, the newly deployed Go server does not provideparent_file_idin its output, since this information is redundant (i.e. it cannot be used in migration process since these ids have no sense in destination database, and moreover python DBSMigration code does not use this information either). As such, I address this issue in this PR to make it compatible with new Go-based DBS server. We may need it during transition period when we would like to runside by side both DBSMigration servers.