Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions bake/hcl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,44 @@ func TestHCLTypedVariables(t *testing.T) {
require.Contains(t, err.Error(), "failed to parse IS_FOO as bool")
}

func TestHCLNullVariableDefault(t *testing.T) {
dt := []byte(`
variable "FOO" {}
target "default" {
args = {
isNull = equal(FOO, null)
isEmptyString = equal(FOO, "")
}
}`)

c, err := ParseFile(dt, "docker-bake.hcl")
require.NoError(t, err)
require.Len(t, c.Targets, 1)
require.Len(t, c.Targets[0].Args, 2)
require.Equal(t, "true", *c.Targets[0].Args["isNull"])
require.Equal(t, "false", *c.Targets[0].Args["isEmptyString"])
}

func TestHCLEmptyVariable(t *testing.T) {
dt := []byte(`
variable "FOO" {
default = ""
}
target "default" {
args = {
isNull = equal(FOO, null)
isEmptyString = equal(FOO, "")
}
}`)

c, err := ParseFile(dt, "docker-bake.hcl")
require.NoError(t, err)
require.Len(t, c.Targets, 1)
require.Len(t, c.Targets[0].Args, 2)
require.Equal(t, "false", *c.Targets[0].Args["isNull"])
require.Equal(t, "true", *c.Targets[0].Args["isEmptyString"])
}

func TestHCLNullVariables(t *testing.T) {
dt := []byte(`
variable "FOO" {
Expand Down
7 changes: 6 additions & 1 deletion bake/hclparser/hclparser.go
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,12 @@ func (p *parser) resolveValue(ectx *hcl.EvalContext, name string) (err error) {
if def == nil {
val, ok := p.opt.Vars[name]
if !ok {
val, _ = p.opt.LookupVar(name)
val, ok = p.opt.LookupVar(name)
if !ok {
vv := cty.NullVal(cty.DynamicPseudoType)
v = &vv
return
}
}
vv := cty.StringVal(val)
v = &vv
Expand Down