-
Notifications
You must be signed in to change notification settings - Fork 161
Add Fedora 43. #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fedora 43. #1249
Conversation
vvoland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, but I think Fedora 43 isn't "out" yet so perhaps we should still give it some time before having official stable packages?
|
In the past we have merged Fedora N support before its actual release (usually around the beta phase where things are stabilizing). If you mark this "not stable" then on the D day of the Fedora release packages won't be available (even after merging this, no new docker/containerd package will be made available until the next containerd/docker actual release, which on occasion can take some time). I try to proactively send pull requests like these since couple of years since I regularly hit the issue that docker (I am especially interested in the docker client) was not installable from the |
|
Thanks! I was missing the bit about Fedora 43 being released as beta this week. In this case I think it's good to have it already. |
Signed-off-by: Romain Geissler <romain.geissler@amadeus.com>
|
@Romain-Geissler-1A do you have a moment to rebase this one? Otherwise I can rebase this one and get it in. |
3897d0d to
c01ffca
Compare
|
I went ahead and rebased this one, hope you don't mind! 🙈 |
|
Thanks for the rebase, I was off yesterday. So, don't we need docker/containerd-packaging#427 as well ? Because the resulting docker rpm packages won't be installable without the required containerd dependency. |
|
No. Sorry for the confusion. We're in the middle of reworking the release pipeline. Currently only In the nearest future (after we get v29 out) the |
Blindly copy the fedora 42 Dockerfile for fedora 43, just change the version number.
- Description for the changelog