Make AbstractManagerRegistry::$proxyInterfaceName nullable
#458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
from
7bb97b8 to
dab9bde
Compare
2 tasks
stof
reviewed
Oct 29, 2025
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
from
dab9bde to
da18d27
Compare
greg0ire
previously approved these changes
Oct 30, 2025
SenseException
previously approved these changes
Oct 30, 2025
Member
|
@GromNaN why are you targeting 3.4.x ? Is this a bugfix? |
Member
Author
|
It's not absolutely a bug since you can pass the |
Member
|
That's not a bug indeed, that's a design issue. I think you should target 4.2.x |
Member
|
Or rather, just close in favor of #460 |
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
from
da18d27 to
f54f31c
Compare
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
2 times, most recently
from
a52f493 to
bf7ed7f
Compare
Member
Author
|
I rebased this PR on 4.2, since #460 is going to be for 5.x. Skipping the |
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
from
bf7ed7f to
1df2243
Compare
GromNaN
force-pushed
the
nullable-proxyInterfaceName
branch
from
1df2243 to
0550eef
Compare
greg0ire
approved these changes
Nov 3, 2025
SenseException
approved these changes
Nov 4, 2025
Member
|
Thanks @GromNaN ! |
GromNaN
added a commit
to GromNaN/doctrine-persistence
that referenced
this pull request
Dec 4, 2025
Conflicts: src/AbstractManagerRegistry.php doctrine#460 doctrine#458
GromNaN
added a commit
to GromNaN/doctrine-persistence
that referenced
this pull request
Dec 4, 2025
Conflicts: src/AbstractManagerRegistry.php doctrine#460 doctrine#458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When native lazy objects are used, there is no proxy class wrapping the entity/document class.