Deprecate ClassMetadataFactory::setMetadataFor()
#461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
deprecate-setMetadataFor
branch
2 times, most recently
from
24e1600 to
11c76c8
Compare
SenseException
previously approved these changes
Oct 31, 2025
Member
|
Please rebase |
GromNaN
force-pushed
the
deprecate-setMetadataFor
branch
from
11c76c8 to
b8d62d8
Compare
greg0ire
approved these changes
Nov 3, 2025
Member
|
Thanks @GromNaN ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is not used by Doctrine ORM or MongoDB ODM.
According to doctrine/orm#12174, updating class metadata directly can lead to unexpected side effects.
Implementations can still have this method or other way to alter the class metadata, mainly for testing purposes, but this should not be exposed by the interface.