Conversation
It is no longer clear to me why I did not make the AbstractManagerRegistry::$connections and AbstractManagerRegistry::$managers readonly already in 59029af.
The class is final and has no parent, so this is fine.
| private array $connections, | ||
| private array $managers, | ||
| private readonly array $connections, | ||
| private readonly array $managers, |
There was a problem hiding this comment.
From my first commit message:
It is no longer clear to me why I did not make the
AbstractManagerRegistry::$connections and
AbstractManagerRegistry::$managers readonly already in
greg0ire@59029af.
If you can imagine a reason why I didn't, let me know. If not, then I guess the best way to find out will be to just do it.
There was a problem hiding this comment.
The @final annotation is duplicating the hard final.
| @@ -165,6 +174,7 @@ public function getManagerNames(): array | |||
| /** | |||
| * {@inheritDoc} | |||
There was a problem hiding this comment.
should be removed. The inline phpdoc tag is only about inheriting the long description (which is only useful when wanting to include it inside the long description define of the child, thing about it as the parent:: call for the phpdoc long description).
The current usage is likely a confusion with the block-level tag @inheritDoc that is meant to say "this method is overriding the parent one which already defines everything so don't complain about missing phpdoc". And the #[Override] already provides that intent.
There was a problem hiding this comment.
@stof should we wait on slevomat/coding-standard#1824 before attempting to address this?
There was a problem hiding this comment.
Thanks for the PR slevomat/coding-standard#1828 @greg0ire. We can remove the phpdoc in all the doctrine projects in an other PR.
| @@ -165,6 +174,7 @@ public function getManagerNames(): array | |||
| /** | |||
| * {@inheritDoc} | |||
There was a problem hiding this comment.
Thanks for the PR slevomat/coding-standard#1828 @greg0ire. We can remove the phpdoc in all the doctrine projects in an other PR.
3 participants
No description provided.