AnimalManager decompilation #83
Merged
+96
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GMSJ01 (d0a2812 - c00aee1)📈 Matched code: 26.64% (+0.03%, +1012 bytes) ✅ 8 new matches
📈 4 improvements in unmatched items
|
Mostly matching - remaining issues (loadAfter frame +16, load frame +40, clipEnemies register allocation shift) seem unsolvable at the moment.
ryanbevins
force-pushed
the
AnimalSave
branch
from
3d8eb18 to
c00aee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Animal/AnimalManager.cpp— 5/7 functions at 100% matchinclude/Animal/AnimalManager.hppwithTAnimalManagerBaseandTMewManagerclass definitionsNotes
Mostly matching. Remaining issues seem unsolvable at the moment:
loadAfter: frame size +16 (likely from an unknown inline wrapper aroundcreateRandPlayVec)load: frame size +40 (same class of issue)clipEnemies: GPR register allocation shift (similar to known FPR f30/f31 swap pattern)